Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate --v2-deprecation and schedule to remove it in 3.8 #19006

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Deprecate --v2-deprecation and schedule to remove it in 3.8 #19006

merged 2 commits into from
Dec 6, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Dec 4, 2024

@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.76%. Comparing base (7e04bd2) to head (f54c8f5).
Report is 17 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/config/v2_deprecation.go 92.30% <ø> (ø)
server/embed/config.go 79.49% <ø> (ø)
server/embed/etcd.go 75.82% <100.00%> (+0.04%) ⬆️
server/etcdmain/config.go 66.66% <100.00%> (-0.23%) ⬇️

... and 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19006      +/-   ##
==========================================
- Coverage   68.77%   68.76%   -0.01%     
==========================================
  Files         420      420              
  Lines       35629    35629              
==========================================
- Hits        24503    24501       -2     
- Misses       9696     9700       +4     
+ Partials     1430     1428       -2

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e04bd2...f54c8f5. Read the comment docs.

@ahrtr ahrtr force-pushed the v2_deprecation_20241204 branch from 6722daf to f54c8f5 Compare December 4, 2024 14:44
@ahrtr
Copy link
Member Author

ahrtr commented Dec 4, 2024

/test pull-etcd-integration-1-cpu-amd64

@ahrtr
Copy link
Member Author

ahrtr commented Dec 6, 2024

ping @serathius

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr
Copy link
Member Author

ahrtr commented Dec 6, 2024

Thanks both @fuweid and @serathius !

@ahrtr ahrtr merged commit 7bb5596 into etcd-io:main Dec 6, 2024
34 checks passed
@ahrtr ahrtr deleted the v2_deprecation_20241204 branch December 6, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuweid fuweid fuweid approved these changes

@serathius serathius serathius approved these changes

Assignees
No one assigned
Labels
approved area/testing size/L
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't allow users to change the value for --v2-deprecation
4 participants
@ahrtr @k8s-ci-robot @serathius @fuweid